Verify types in IR #21216
Merged
Verify types in IR #21216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
tests:hive
iceberg
martint
force-pushed
the
ir-verify-types
branch
from
c78567d to
c9801a3
Compare
wendigo
reviewed
Mar 22, 2024
martint
force-pushed
the
ir-verify-types
branch
2 times, most recently
from
4e0e533 to
73c87ac
Compare
dain
approved these changes
Mar 23, 2024
Member
There was a problem hiding this comment.
These should match the operator... matching each other it nice also
Member
Author
There was a problem hiding this comment.
We don't have the ResolvedFunction in Comparison yet. Once I add it, we can also validate against it.
Member
There was a problem hiding this comment.
you could add the Optional<ResolvedFunction> for the coercion and then the verification is easier.. also you likely need the resolved equals function here
martint
force-pushed
the
ir-verify-types
branch
from
73c87ac to
aa739b2
Compare
wendigo
approved these changes
Mar 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.