Add types to IR nodes and remove type analyzer/provider #21192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
tests:hive
iceberg
dain
approved these changes
Mar 21, 2024
Member
dain
left a comment
dain
left a comment
There was a problem hiding this comment.
My suggestion are for future follow work, not for now.
Member
There was a problem hiding this comment.
We should enforce that all clauses have the same result type in the constructor
Member
There was a problem hiding this comment.
We should enforce all of the operands have the same type in the constructor
Member
There was a problem hiding this comment.
We should enforce the argument types match the bound signature in the constructor
Member
Author
Yeah, planning to do that too. It will require fixing many tests that are currently malformed. |
No longer needed since IR expression now carry their types.
martint
force-pushed
the
ir-types-remaining
branch
from
d8598f5 to
f084f55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.