Skip to content

Conversation

@guptashailesh92
Copy link
Contributor

@guptashailesh92 guptashailesh92 commented Mar 19, 2024

Description

Hive supports hive.lazysimple.extended_boolean_literal for LazySimpleSerde.

LazySimpleSerde uses this property to determine if it treats 'T', 't', 'F', 'f', '1', and '0' as extended, legal boolean literal, in addition to 'TRUE' and 'FALSE'. The default is false, which means only 'TRUE' and 'FALSE' are treated as legal boolean literal.

Adding the same here.

Additional context and related issues

Release notes

# Hive
* Add support for `extended_boolean_literal` in text-file formats. ({issue}`21156`)

@cla-bot cla-bot bot added the cla-signed label Mar 19, 2024
@Praveen2112
Copy link
Member

Can we refer the code link from Apache Hive as a part of commit message and PR description so that we could know where to look in the future.

Copy link
Member

@Praveen2112 Praveen2112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this. Can we also add a test in TestTextFileHiveTable to ensure that we mimic's hive's behavior.

@wendigo
Copy link
Contributor

wendigo commented Mar 20, 2024

@Praveen2112 PTAL

@Praveen2112
Copy link
Member

Sure @wendigo I'm looking for PTs which ensure the behavior

@github-actions
Copy link

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

@github-actions
Copy link

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

@github-actions github-actions bot added the stale label May 10, 2024
@github-actions
Copy link

github-actions bot commented Jun 3, 2024

Closing this pull request, as it has been stale for six weeks. Feel free to re-open at any time.

@github-actions github-actions bot closed this Jun 3, 2024
@mosabua mosabua reopened this Jun 3, 2024
@mosabua mosabua added stale-ignore Use this label on PRs that should be ignored by the stale bot so they are not flagged or closed. and removed stale labels Jun 3, 2024
@mosabua
Copy link
Member

mosabua commented Jun 3, 2024

I reopened @Praveen2112 @wendigo since this still seems a valid improvement. Do you need any further help besides time to review?

@ebyhr ebyhr removed the stale-ignore Use this label on PRs that should be ignored by the stale bot so they are not flagged or closed. label Jul 23, 2025
@github-actions
Copy link

This pull request has gone a while without any activity. Ask for help on #core-dev on Trino slack.

@github-actions github-actions bot added the stale label Aug 13, 2025
@wendigo
Copy link
Contributor

wendigo commented Aug 14, 2025

@Praveen2112 I think that the unit test is enough in that case. I'm going to merge this change (I've applied some stylistic improvements)

@wendigo wendigo merged commit 22eecc9 into trinodb:master Aug 14, 2025
60 checks passed
@github-actions github-actions bot added this to the 477 milestone Aug 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

6 participants