-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Support for extended boolean literal for LazySimpleSerde #21156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Can we refer the code link from Apache Hive as a part of commit message and PR description so that we could know where to look in the future. |
Praveen2112
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this. Can we also add a test in TestTextFileHiveTable to ensure that we mimic's hive's behavior.
lib/trino-hive-formats/src/main/java/io/trino/hive/formats/encodings/text/BooleanEncoding.java
Outdated
Show resolved
Hide resolved
121468b to
4918649
Compare
lib/trino-hive-formats/src/main/java/io/trino/hive/formats/encodings/text/BooleanEncoding.java
Outdated
Show resolved
Hide resolved
lib/trino-hive-formats/src/main/java/io/trino/hive/formats/encodings/text/BooleanEncoding.java
Outdated
Show resolved
Hide resolved
4918649 to
c60f802
Compare
|
@Praveen2112 PTAL |
|
Sure @wendigo I'm looking for PTs which ensure the behavior |
|
This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua |
|
This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua |
|
Closing this pull request, as it has been stale for six weeks. Feel free to re-open at any time. |
|
I reopened @Praveen2112 @wendigo since this still seems a valid improvement. Do you need any further help besides time to review? |
|
This pull request has gone a while without any activity. Ask for help on #core-dev on Trino slack. |
c60f802 to
8a0ab28
Compare
|
@Praveen2112 I think that the unit test is enough in that case. I'm going to merge this change (I've applied some stylistic improvements) |
Description
Hive supports
hive.lazysimple.extended_boolean_literalforLazySimpleSerde.Adding the same here.
Additional context and related issues
Release notes