Use non-English locale on CI #21140
Closed
Use non-English locale on CI #21140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests must not depend on the system locale. It is expected that tests pass on every machine and that locale is fixed, if needed, on maven level. While Trino sets en_US (via air.test.language, air.test.region), set environment to something else to ensure the environment has no effect when undesired.
Member
Author
|
As should be expected. No tests failed, but it doesn't mean there isn't a problem. I think we could also run server with fixed locale, to force server into scope that's tested & guaranteed to work. @trinodb/maintainers thoughts? |
Contributor
|
@findepi maybe we can assign some predefined list of locales in a round robin fashion to different jobs? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests must not depend on the system locale. It is expected that tests pass on every machine and that locale is fixed, if needed, on maven level. While Trino sets en_US (via air.test.language, air.test.region), set environment to something else to ensure the environment has no effect when undesired.
Relates to #21136