Add test for symlink tables using line-based input formats #21139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a regression test for trinodb#21072. Note that while the test is explicitly testing only against textfile tables same can be done against any other LinePageSourceFactory based input formats (CSV, JSON, Regex, Sequence-file and Textfile for example).
hashhar
force-pushed
the
hashhar/symlink-line-regression-test
branch
from
1dfe442 to
4bad135
Compare
wendigo
approved these changes
Mar 18, 2024
Member
thank you! |
findepi
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This basically adds a regression test for
#21072.
Note that while the test is explicitly testing only against textfile tables same can be done against any other LinePageSourceFactory based input formats (CSV, JSON, Regex, Sequence-file and Textfile for example).
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.