Drop explicit check for file existence while creating GCS blobs #21105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Maintainer, pls test the PR with secrets |
wendigo
approved these changes
Mar 15, 2024
Member
|
/test-with-secrets sha=175d8f1ddf77f417e875022e310730681bee640e |
|
The CI workflow run with tests that require additional secrets has been started: https://github.com/trinodb/trino/actions/runs/8302079842 |
electrum
reviewed
Mar 15, 2024
lib/trino-filesystem/src/test/java/io/trino/filesystem/AbstractTestTrinoFileSystem.java
Outdated
Show resolved
Hide resolved
findepi
approved these changes
Mar 15, 2024
Defer the file existence check to GCS API when the blob gets actually created.
findinpath
force-pushed
the
findinpath/gcs-drop-explicit-file-already-exists-check
branch
from
175d8f1 to
b3bae09
Compare
Contributor
Author
|
Unrelated CI failure #18697 |
wendigo
approved these changes
Mar 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Defer the file existence check to GCS API when the blob gets actually created.
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: