Simplify implementation of literals in IR #21103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martint
force-pushed
the
ir-string
branch
2 times, most recently
from
f03d825 to
06ac005
Compare
martint
changed the title
martint
changed the title
martint
force-pushed
the
ir-string
branch
2 times, most recently
from
5223cc2 to
c689bb3
Compare
martint
changed the title
dain
approved these changes
Mar 16, 2024
core/trino-main/src/main/java/io/trino/sql/planner/TranslationMap.java
Outdated
Show resolved
Hide resolved
martint
force-pushed
the
ir-string
branch
4 times, most recently
from
0a2fbda to
8146de6
Compare
It wasn't handling the case where the fields showed up as a literal row in the optimizer rule.
No longer needed, since literals are now serializable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Literals are now encoded using their native carrier type. The
$literal$function hack is now gone, too.Release notes
(x) This is not user-visible or is docs only, and no release notes are required.