Draft: Use manifest file caching for Iceberg#20862
Closed
findinpath wants to merge 1 commit intotrinodb:masterfrom
Closed
Draft: Use manifest file caching for Iceberg#20862findinpath wants to merge 1 commit intotrinodb:masterfrom
findinpath wants to merge 1 commit intotrinodb:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PoC to see whether the internal manifest file caching feature from Iceberg could be used in Trino.
At the time of this writing, the main limitation in Trino to use this feature is that each time a storage operation is done, a new
ForwardingFileIoinstance is being created, while theCONTENT_CACHESstatic field from Iceberg awaits the sameFileIOinstance to retrieve a certain content cache.https://github.com/apache/iceberg/blob/6a3b2d7c153412b01c746debb018c544516f2bbd/core/src/main/java/org/apache/iceberg/ManifestFiles.java#L73-L79
Additional context and related issues
apache/iceberg#4518
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: