Delta Lake: Add partitionValues information to the remove transaction log entries
#20492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findinpath
force-pushed
the
findinpath/delta-remove-entry-partition-values
branch
2 times, most recently
from
3f10869 to
1d313af
Compare
Member
|
@ebyhr @alexjo2144 can you PTAL? |
ebyhr
reviewed
Feb 15, 2024
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeMergeResult.java
Outdated
Show resolved
Hide resolved
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeScannedDataFile.java
Outdated
Show resolved
Hide resolved
...trino-delta-lake/src/main/java/io/trino/plugin/deltalake/transactionlog/RemoveFileEntry.java
Outdated
Show resolved
Hide resolved
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeSplitSource.java
Outdated
Show resolved
Hide resolved
|
This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua |
findinpath
force-pushed
the
findinpath/delta-remove-entry-partition-values
branch
from
1d313af to
cc57c0b
Compare
findinpath
force-pushed
the
findinpath/delta-remove-entry-partition-values
branch
from
cc57c0b to
6b70e25
Compare
findinpath
force-pushed
the
findinpath/delta-remove-entry-partition-values
branch
from
6b70e25 to
46c88da
Compare
ebyhr
approved these changes
Mar 15, 2024
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeMergeResult.java
Outdated
Show resolved
Hide resolved
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeMetadata.java
Outdated
Show resolved
Hide resolved
findinpath
force-pushed
the
findinpath/delta-remove-entry-partition-values
branch
from
46c88da to
99e2acd
Compare
This information can be particularly useful in the context of concurrent writes operations to identify overlaps between the partitions being read by the current operation and the partitions updated by an already committed operation.
ebyhr
force-pushed
the
findinpath/delta-remove-entry-partition-values
branch
from
99e2acd to
7981efc
Compare
Member
|
Shorten the commit title and removed a redundant space from commit message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This information can be particularly useful in the context of concurrent writes operations to identify overlaps between the partitions being read by the current operation and the partitions updated by an already committed operation.
Additional context and related issues
#18506
https://github.com/delta-io/delta/blob/master/PROTOCOL.md#add-file-and-remove-file
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: