-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Improve char type and comparison docs #20457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martint
reviewed
Jan 26, 2024
@martint I stripped down the char type docs and added an examples section in comparison page. And fixed up format and styling.. |
This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua |
Waiting for final review from @martint |
martint
reviewed
Apr 4, 2024
30a0a73
to
503a8d5
Compare
Maybe @kasiafi can chime in and help moving this forward? Please ... |
martint
approved these changes
Jan 27, 2025
Thanks @martint |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cla-signed
docs
stale-ignore
Use this label on PRs that should be ignored by the stale bot so they are not flagged or closed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up to https://trinodb.slack.com/archives/CP1MUNEUX/p1705983989648189
Additional context and related issues
None
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.