Add support for ALTER COLUMN ... DROP NOT NULL statement in Iceberg and PostgreSQL connectors
#20366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
docs
iceberg
ebyhr
force-pushed
the
ebi/drop-not-null
branch
from
bfe8661 to
09176e2
Compare
ebyhr
force-pushed
the
ebi/drop-not-null
branch
3 times, most recently
from
3a3de95 to
2ae4b4f
Compare
hashhar
approved these changes
Jan 16, 2024
Member
hashhar
left a comment
hashhar
left a comment
There was a problem hiding this comment.
LGTM % "Add support for DROP NOT NULL in Iceberg" which I could not review with sufficient depth.
core/trino-main/src/main/java/io/trino/execution/DropNotNullTask.java
Outdated
Show resolved
Hide resolved
martint
reviewed
Jan 16, 2024
core/trino-grammar/src/main/antlr4/io/trino/grammar/sql/SqlBase.g4
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/execution/DropNotNullTask.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/execution/DropNotNullTask.java
Outdated
Show resolved
Hide resolved
core/trino-parser/src/main/java/io/trino/sql/tree/DropNotNull.java
Outdated
Show resolved
Hide resolved
Member
Author
|
@martint Should we rename method in SPI as well? |
martint
reviewed
Jan 19, 2024
core/trino-main/src/main/java/io/trino/execution/DropNotNullContraintTask.java
Outdated
Show resolved
Hide resolved
core/trino-parser/src/main/java/io/trino/sql/tree/AstVisitor.java
Outdated
Show resolved
Hide resolved
core/trino-parser/src/main/java/io/trino/sql/tree/DropNotNullConstraint.java
Outdated
Show resolved
Hide resolved
core/trino-spi/src/main/java/io/trino/spi/connector/ConnectorMetadata.java
Outdated
Show resolved
Hide resolved
...toolkit/src/main/java/io/trino/plugin/base/classloader/ClassLoaderSafeConnectorMetadata.java
Outdated
Show resolved
Hide resolved
plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/BaseJdbcClient.java
Outdated
Show resolved
Hide resolved
plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/CachingJdbcClient.java
Outdated
Show resolved
Hide resolved
plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/JdbcClient.java
Outdated
Show resolved
Hide resolved
testing/trino-tests/src/test/java/io/trino/security/TestAccessControl.java
Outdated
Show resolved
Hide resolved
ebyhr
force-pushed
the
ebi/drop-not-null
branch
from
1733a9e to
293411c
Compare
Member
Author
|
Rebased on master to resolve conflicts. |
ebyhr
force-pushed
the
ebi/drop-not-null
branch
from
293411c to
92d5a2e
Compare
findinpath
reviewed
Jan 19, 2024
core/trino-main/src/main/java/io/trino/tracing/TracingMetadata.java
Outdated
Show resolved
Hide resolved
findinpath
reviewed
Jan 19, 2024
core/trino-main/src/test/java/io/trino/execution/TestDropNotNullConstraintConstraintTask.java
Outdated
Show resolved
Hide resolved
findinpath
reviewed
Jan 19, 2024
core/trino-main/src/test/java/io/trino/execution/TestDropNotNullConstraintConstraintTask.java
Outdated
Show resolved
Hide resolved
findinpath
reviewed
Jan 19, 2024
plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeConnectorTest.java
Outdated
Show resolved
Hide resolved
ebyhr
force-pushed
the
ebi/drop-not-null
branch
from
92d5a2e to
fa2e973
Compare
findinpath
approved these changes
Jan 20, 2024
Contributor
findinpath
left a comment
findinpath
left a comment
There was a problem hiding this comment.
LGTM
Didn't review though extensively the PostgreSQL related commits
Member
Author
|
@martint Could you please take another look? |
martint
approved these changes
Jan 26, 2024
core/trino-parser/src/main/java/io/trino/sql/tree/DropNotNullConstraint.java
Outdated
Show resolved
Hide resolved
ebyhr
force-pushed
the
ebi/drop-not-null
branch
from
fa2e973 to
13c0e6f
Compare
ebyhr
force-pushed
the
ebi/drop-not-null
branch
from
13c0e6f to
53e8b43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #20315
Release notes
(x) Release notes are required, with the following suggested text: