Process only files smaller than the threshold for OPTIMIZE#20121
Merged
findepi merged 1 commit intotrinodb:masterfrom Dec 15, 2023
Merged
Process only files smaller than the threshold for OPTIMIZE#20121findepi merged 1 commit intotrinodb:masterfrom
findepi merged 1 commit intotrinodb:masterfrom
Conversation
findepi
reviewed
Dec 14, 2023
Member
findepi
left a comment
findepi
left a comment
There was a problem hiding this comment.
"Rewrite data file filtering logic for OPTIMIZE statements"
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeSplitManager.java
Outdated
Show resolved
Hide resolved
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeSplitManager.java
Outdated
Show resolved
Hide resolved
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeSplitManager.java
Outdated
Show resolved
Hide resolved
Filter for processing the files which are smaller than the threshold and consider a partition for optimization if and only if it contains at least two such files.
findinpath
force-pushed
the
findinpath/delta-optimize-bugfix
branch
from
56687b3 to
355311a
Compare
findepi
approved these changes
Dec 15, 2023
Contributor
|
Thanks a lot for fixing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #20088
Additional context and related issues
Commits are taken out of #20054
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: