Skip to content

Fix incorrect LIKE for patterns with repeating substrings #20100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martint merged 1 commit into from
Dec 13, 2023
Merged

Fix incorrect LIKE for patterns with repeating substrings #20100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/trino-main/src/main/java/io/trino/likematcher/FjsMatcher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ else if (matchEnd >= inputLimit - 1) {
j = kmpShifts[j];

// Continue to match the whole pattern using KMP
while (j > 0) {
while (j >= 0) {
int size = findLongestMatch(input, i, pattern, j, Math.min(inputLimit - i, pattern.length - j));
i += size;
j += size;
Expand Down
6 changes: 6 additions & 0 deletions core/trino-main/src/test/java/io/trino/likematcher/TestLikeMatcher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,12 @@ public void test()

assertFalse(match("%abaaa%", "ababaa"));

assertTrue(match("%paya%", "papaya"));
assertTrue(match("%paya%", "papapaya"));
assertTrue(match("%paya%", "papapapaya"));
assertTrue(match("%paya%", "papapapapaya"));
assertTrue(match("%paya%", "papapapapapaya"));

// utf-8
LikeMatcher singleOptimized = LikePattern.compile("_", Optional.empty(), true).getMatcher();
LikeMatcher multipleOptimized = LikePattern.compile("_a%b_", Optional.empty(), true).getMatcher(); // prefix and suffix with _a and b_ to avoid optimizations
Expand Down