Skip to content

Add a config to toggle local scheduling of Mongo splits#20078

Merged
Praveen2112 merged 1 commit intotrinodb:masterfrom
Praveen2112:praveen/mongodb_local_splits
Dec 13, 2023
Merged

Add a config to toggle local scheduling of Mongo splits#20078
Praveen2112 merged 1 commit intotrinodb:masterfrom
Praveen2112:praveen/mongodb_local_splits

Conversation

@Praveen2112
Copy link
Copy Markdown
Member

Additionally disable local scheduling of Mongo splits

Description

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text:

# Section
* Add a config to toggle local scheduling of Mongo splits. ({issue}`issuenumber`)

Additionally disable local scheduling of Mongo splits
@cla-bot cla-bot bot added the cla-signed label Dec 11, 2023
@github-actions github-actions bot added the mongodb MongoDB connector label Dec 11, 2023
@@ -45,6 +45,7 @@ public class MongoClientConfig
private String requiredReplicaSetName;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally disable local scheduling of Mongo splits

Why "additionally"

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We disable it by default as enabling couples the storage and compute layer i.e split would be assigned to the worker which is shared with MongoDB which might cause some contention of resources.

@Praveen2112 Praveen2112 merged commit 3cbf498 into trinodb:master Dec 13, 2023
@github-actions github-actions bot added this to the 435 milestone Dec 13, 2023
@mosabua
Copy link
Copy Markdown
Member

mosabua commented Dec 14, 2023

@Praveen2112 I changed the release notes entry and sent a PR for the missing docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed mongodb MongoDB connector

Development

Successfully merging this pull request may close these issues.

5 participants