Use correct HostnameVerifier when verify-hostnames set to true#20076
Merged
Praveen2112 merged 1 commit intotrinodb:masterfrom Dec 12, 2023
Merged
Conversation
Previously we were using `NoopHostnameVerifier` which turns off hostname verification, if the HostnameVerifier is not set it uses `DefaultHostnameVerifier` which performs hostname verification
krvikash
approved these changes
Dec 11, 2023
kokosing
approved these changes
Dec 11, 2023
...no-elasticsearch/src/main/java/io/trino/plugin/elasticsearch/client/ElasticsearchClient.java
Show resolved
Hide resolved
ebyhr
approved these changes
Dec 12, 2023
martint
approved these changes
Dec 12, 2023
marcinsbd
approved these changes
Dec 12, 2023
Member
|
I think this is potentially a breaking change @martint although the property defaults to true and is also not documented @Praveen2112 can you send docs? I also reworded the release notes entry. |
Member
|
It's a bug fix, really, so if someone were depending on the incorrect behavior it would appear to be a breaking change. I don't think it warrants being marked as a breaking change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously we were using
NoopHostnameVerifierwhich turns off hostname verification, and if the HostnameVerifier is not set it usesDefaultHostnameVerifierwhich performs hostname verificationAdditional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: