Skip to content

Support for 0 length dictionary copyRegion #20065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sopel39 merged 1 commit into from
Dec 9, 2023
Merged

Support for 0 length dictionary copyRegion #20065

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions core/trino-spi/src/main/java/io/trino/spi/block/DictionaryBlock.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,6 +420,9 @@ public Block getRegion(int positionOffset, int length)
public Block copyRegion(int position, int length)
{
checkValidRegion(positionCount, position, length);
if (length == 0) {
Comment thread
sopel39 marked this conversation as resolved.
Outdated
return dictionary.copyRegion(0, 0);
}
// Avoid repeated volatile reads to the uniqueIds field
int uniqueIds = this.uniqueIds;
if (length <= 1 || (uniqueIds == dictionary.getPositionCount() && isSequentialIds)) {
Expand Down