Skip to content

Add example SQL routines for formatting bytes#20061

Merged
mosabua merged 1 commit intotrinodb:masterfrom
nineinchnick:format_data_size-routines
Dec 12, 2023
Merged

Add example SQL routines for formatting bytes#20061
mosabua merged 1 commit intotrinodb:masterfrom
nineinchnick:format_data_size-routines

Conversation

@nineinchnick
Copy link
Copy Markdown
Member

Description

Add example SQL routines for formatting bytes

Additional context and related issues

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

@cla-bot cla-bot bot added the cla-signed label Dec 8, 2023
@nineinchnick nineinchnick requested a review from mosabua December 8, 2023 17:02
@github-actions github-actions bot added the docs label Dec 8, 2023
@mosabua mosabua force-pushed the format_data_size-routines branch from 83801c6 to eb47239 Compare December 12, 2023 00:57
Co-authored-by: Jan Waś <jan.was@starburstdata.com>
@mosabua mosabua force-pushed the format_data_size-routines branch from eb47239 to 1df03cb Compare December 12, 2023 01:01
@mosabua
Copy link
Copy Markdown
Member

mosabua commented Dec 12, 2023

Rebased and minor rewording done. @nineinchnick somehow that dropped you as author.. so I added you as co-author. Feel free to just push again from your end .. or let me know if this is fine. Once I know this is ready to merge. Will look at more examples in the next days.

Copy link
Copy Markdown
Member Author

@nineinchnick nineinchnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@mosabua mosabua merged commit 794c8dd into trinodb:master Dec 12, 2023
@github-actions github-actions bot added this to the 435 milestone Dec 12, 2023
@nineinchnick nineinchnick deleted the format_data_size-routines branch May 27, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants