Skip to content

Upgrade GCS connector to 3.0.0#20056

Merged
wendigo merged 1 commit intomasterfrom
serafin/gcs-connector-v3
Dec 8, 2023
Merged

Upgrade GCS connector to 3.0.0#20056
wendigo merged 1 commit intomasterfrom
serafin/gcs-connector-v3

Conversation

@wendigo
Copy link
Contributor

@wendigo wendigo commented Dec 8, 2023

On previous version:

public static final ImmutableList<String> DEFAULT_SCOPES = ImmutableList.of("https://www.googleapis.com/auth/cloud-platform");

On previous version:

```
public static final ImmutableList<String> DEFAULT_SCOPES = ImmutableList.of("https://www.googleapis.com/auth/cloud-platform");
```
Copy link
Member

@kokosing kokosing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anusudarsan Do you have context here?

@wendigo What test coverage we have for this? Were tests executed?

@wendigo
Copy link
Contributor Author

wendigo commented Dec 8, 2023

@kokosing we don't have a coverage for GCS, we never did. I checked the connectivity with a hive catalog locally and it seems to work.

@wendigo wendigo merged commit 81b7638 into master Dec 8, 2023
@wendigo wendigo deleted the serafin/gcs-connector-v3 branch December 8, 2023 15:15
@github-actions github-actions bot added this to the 435 milestone Dec 8, 2023
@findinpath
Copy link
Contributor

findinpath commented Dec 8, 2023

@kokosing we don't have a coverage for GCS, we never did. I checked the connectivity with a hive catalog locally and it seems to work.

We have integration tests running against GCS.
See:

We do have product tests running against GCS .
See:

@findinpath
Copy link
Contributor

@wendigo
Copy link
Contributor Author

wendigo commented Dec 8, 2023

@findinpath is it executed against GCS?

@findinpath
Copy link
Contributor

Yes, sure.

@wendigo
Copy link
Contributor Author

wendigo commented Dec 8, 2023

@findinpath good to know that this change works :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants