Conversation
On previous version:
```
public static final ImmutableList<String> DEFAULT_SCOPES = ImmutableList.of("https://www.googleapis.com/auth/cloud-platform");
```
kokosing
approved these changes
Dec 8, 2023
Member
kokosing
left a comment
There was a problem hiding this comment.
@anusudarsan Do you have context here?
@wendigo What test coverage we have for this? Were tests executed?
Contributor
Author
|
@kokosing we don't have a coverage for GCS, we never did. I checked the connectivity with a hive catalog locally and it seems to work. |
Contributor
We have integration tests running against GCS.
We do have product tests running against GCS .
|
Contributor
|
Release notes for 3.0.0-RC1 |
Contributor
Author
|
@findinpath is it executed against GCS? |
Contributor
|
Yes, sure. |
Contributor
Author
|
@findinpath good to know that this change works :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On previous version: