Skip to content

Produce a more actionable error on wrong JDBC URL #20052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wendigo merged 1 commit into from
Dec 7, 2023
Merged

Produce a more actionable error on wrong JDBC URL #20052

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/TracingDataSource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
import java.util.Properties;
import java.util.logging.Logger;

import static com.google.common.base.Preconditions.checkState;
import static java.util.Objects.requireNonNull;

public class TracingDataSource
Expand Down Expand Up @@ -70,7 +71,9 @@ public JdbcDataSource(Driver driver, String connectionUrl, Properties properties
public Connection getConnection()
throws SQLException
{
return driver.connect(connectionUrl, properties);
Connection connection = driver.connect(connectionUrl, properties);
checkState(connection != null, "Driver returned null connection, make sure the connection URL '%s' is valid for the driver %s", connectionUrl, driver);
return connection;
}

@Override
Expand Down