Rely only on table handle for stopping condition#20041
Merged
findepi merged 3 commits intotrinodb:masterfrom Dec 8, 2023
Merged
Rely only on table handle for stopping condition#20041findepi merged 3 commits intotrinodb:masterfrom
findepi merged 3 commits intotrinodb:masterfrom
Conversation
In order to avoid a potential infinite loop at IterativeOptimizer with Iceberg
assaf2
requested review from
Praveen2112,
ebyhr,
findepi,
findinpath,
marton-bod and
raunaqmorarka
alexjo2144
approved these changes
Dec 7, 2023
findepi
approved these changes
Dec 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to avoid a potential infinite loop at IterativeOptimizer with Iceberg
Description
Rely on the data in the table handle instead of
Constraintfor stopping condition.According to my check, we don't see an infinite loop only because
io.trino.sql.planner.iterative.rule.PushPredicateIntoTableScan#arePlansSamereturnstrueand stops the iterative process. If in the futureio.trino.plugin.iceberg.IcebergTableHandle#equalswill returnfalsewhen comparing 2 tables of 2 different iterations, then we'll see an infinite loop. That's whileio.trino.spi.connector.ConnectorTableHandleis an empty interface that doesn't declareequals().Additional context and related issues
This is another case in continue to #20007 and #19876.
Release notes
( X ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: