Merged
Conversation
Member
Author
|
cc @gaurav8297 |
Only update the scaling state if the memory used is below the limit. Otherwise, if we keep updating the scaling state and the memory used is fluctuating around the limit, then we could do massive scaling in a single rebalancing cycle which could cause OOM error.
Since we estimate the partitionDataSize based on partitionRowCount and total data processed. It is possible that the estimated partitionDataSize is slightly less than it was estimated at the last rebalance cycle. That's because for a given partition, row count hasn't increased, however overall data processed has increased. Therefore, we need to make sure that the estimated partitionDataSize since last rebalance is always greater than 0. Otherwise, it will affect the ordering of minTaskBuckets priority queue.
This was referenced Dec 6, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#19973 with fixups on top (already approved)