Skip to content

Cleanup JSON response from TaskInfoFetcher #20022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sopel39 merged 1 commit into from
Dec 5, 2023
Merged

Cleanup JSON response from TaskInfoFetcher #20022

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions core/trino-main/src/main/java/io/trino/server/remotetask/TaskInfoFetcher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,6 +298,9 @@ public void success(TaskInfo newValue)
errorTracker.requestSucceeded();
updateTaskInfo(newValue);
}
finally {
cleanupRequest();
}
}

@Override
Expand All @@ -320,6 +323,9 @@ public void failed(Throwable cause)
onFail.accept(e);
}
}
finally {
cleanupRequest();
}
}

@Override
Expand All @@ -328,6 +334,17 @@ public void fatal(Throwable cause)
try (SetThreadName ignored = new SetThreadName("TaskInfoFetcher-%s", taskId)) {
onFail.accept(cause);
}
finally {
cleanupRequest();
}
}
}

private synchronized void cleanupRequest()
{
if (future != null && future.isDone()) {
// remove outstanding reference to JSON response
future = null;
}
}

Expand Down