Do not fail stage after already done#20002
Merged
losipiuk merged 1 commit intotrinodb:masterfrom Dec 2, 2023
Merged
Conversation
Ignore failure within stage execution if it already done. This is to work around the problem which was introduced with trinodb@39b04491c05. With that change we close EventDrivenTaskSource when stage completes, and as a result of that it may emit an failure event due to internall processes being cancelled. Handling of event in `StageExecution.fail()` did close a number of objects needed for query completion (see createStageExecutionCloser()). As a result the query could hang.
wendigo
approved these changes
Dec 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignore failure within stage execution if it already done. This is to work around the problem which was introduced with 39b04491c05. With that change we close EventDrivenTaskSource when stage completes, and as a result of that it may emit an failure event due to internall processes being cancelled.
Handling of event in
StageExecution.fail()did close a number of objects needed for query completion (see createStageExecutionCloser()). As a result the query could hang.Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: