Introduce MongoTransactionManager#19990
Merged
Praveen2112 merged 3 commits intotrinodb:masterfrom Dec 11, 2023
Merged
Conversation
Praveen2112
force-pushed
the
praveen/mongodb_cleanup
branch
from
ba33384 to
e0c7c03
Compare
krvikash
approved these changes
Dec 4, 2023
| if (tableHandle == null) { | ||
| throw new TableNotFoundException(schemaTableName, format("Table '%s.%s' not found", database, collection), null); | ||
| } | ||
| RemoteTableName remoteTableName = metadata.getTableHandle(session, new SchemaTableName(database, collection)).getRemoteTableName(); |
Contributor
There was a problem hiding this comment.
Why not use tableHandle.getRemoteTableName(); here? We can avoid calling getTableHandle again?
| parseFilter(filter); | ||
|
|
||
| MongoTableHandle tableHandle = new MongoTableHandle(new SchemaTableName(database, collection), remoteTableName, Optional.of(filter)); | ||
| tableHandle = new MongoTableHandle(new SchemaTableName(database, collection), remoteTableName, Optional.of(filter)); |
Contributor
There was a problem hiding this comment.
can we use schemaTableName here instead new SchemaTableName(database, collection)?
Contributor
There was a problem hiding this comment.
readOnly and autoCommit is unused
marcinsbd
reviewed
Dec 5, 2023
Contributor
There was a problem hiding this comment.
nit: I would split this method from this line
marcinsbd
approved these changes
Dec 5, 2023
Praveen2112
force-pushed
the
praveen/mongodb_cleanup
branch
from
e0c7c03 to
2d20940
Compare
Member
Author
|
@marcinsbd / @krvikash Thanks for the review. AC |
ebyhr
approved these changes
Dec 8, 2023
Member
There was a problem hiding this comment.
Why not throw new TableNotFoundException(schemaTableName)? database and collection variables are ensured as lowercases.
Praveen2112
force-pushed
the
praveen/mongodb_cleanup
branch
from
2d20940 to
f757f10
Compare
Member
Author
|
@ebyhr Thanks a lot for the review. AC |
marcinsbd
approved these changes
Dec 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Minor cleanups in Mongo connector which introduces
MongoTransactionManagerAdditional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: