Skip to content

Make S3FileSystemFactory use configured AWS access keys for STS calls#19982

Merged
findepi merged 1 commit intotrinodb:masterfrom
grantatspothero:gn/fixS3FilesystemSTS
Dec 1, 2023
Merged

Make S3FileSystemFactory use configured AWS access keys for STS calls#19982
findepi merged 1 commit intotrinodb:masterfrom
grantatspothero:gn/fixS3FilesystemSTS

Conversation

@grantatspothero
Copy link
Contributor

Description

S3FileSystemFactory STSClient does not use the trino configured AWS access key/secret to connect to STS.

This is an [unintentional] change in behavior from TrinoS3Filesystem which uses the configured trino AWS access key/secret to connect to STS.

Additional context and related issues

I was able to manually test this fix locally by:

  • creating an AWS user with permissions to assume a role, but no other permissions
  • creating a role with permissions to read/write to an s3 bucket
  • configuring the iceberg connector to use the native-s3 filesystem with the above user access credentials and role and then successfully reading/writing tables to the s3 bucket

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
(x) Release notes are required. Please propose a release note for me.
() Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Nov 30, 2023
@findepi findepi merged commit 89a703e into trinodb:master Dec 1, 2023
@github-actions github-actions bot added this to the 435 milestone Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants