Skip to content

Use concurrent hash map for tracking query memory#19978

Merged
sopel39 merged 1 commit intotrinodb:masterfrom
gaurav8297:concurrent_hash_map
Dec 6, 2023
Merged

Use concurrent hash map for tracking query memory#19978
sopel39 merged 1 commit intotrinodb:masterfrom
gaurav8297:concurrent_hash_map

Conversation

@gaurav8297
Copy link
Copy Markdown
Member

@gaurav8297 gaurav8297 commented Nov 30, 2023

This will increase the performance of getQueryMemoryReservation(queryId) method since that is called from every different local exchange thread.

Extracted from #19649

Description

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Nov 30, 2023
@gaurav8297 gaurav8297 marked this pull request as ready for review November 30, 2023 16:04
@gaurav8297 gaurav8297 force-pushed the concurrent_hash_map branch 2 times, most recently from 0d0381a to 66e8869 Compare November 30, 2023 16:23
@sopel39 sopel39 requested a review from losipiuk November 30, 2023 16:39
@gaurav8297 gaurav8297 requested a review from sopel39 November 30, 2023 16:39
Copy link
Copy Markdown
Member

@sopel39 sopel39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's ok as queryMemoryReservations is never in incorrect (in-between) state itself, @losipiuk PTAL also

This will increase the performance of
getQueryMemoryReservation(queryId) method since
that is called from every different
local exchange thread.
@sopel39 sopel39 merged commit ac44709 into trinodb:master Dec 6, 2023
@sopel39 sopel39 added the no-release-notes This pull request does not require release notes entry label Dec 6, 2023
@github-actions github-actions bot added this to the 435 milestone Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed no-release-notes This pull request does not require release notes entry

Development

Successfully merging this pull request may close these issues.

2 participants