Add shutdown to EventListener#19957
Merged
wendigo merged 1 commit intotrinodb:masterfrom Nov 30, 2023
Merged
Conversation
dominikzalewski
force-pushed
the
plugin_lifecycle_manager
branch
3 times, most recently
from
65a2213 to
e2125a8
Compare
dominikzalewski
requested review from
electrum,
findepi,
hashhar,
jdintruff,
kokosing,
raghavsethi,
s2lomon and
wendigo
findepi
reviewed
Nov 29, 2023
core/trino-main/src/main/java/io/trino/eventlistener/EventListenerManager.java
Outdated
Show resolved
Hide resolved
wendigo
requested changes
Nov 29, 2023
core/trino-main/src/main/java/io/trino/eventlistener/EventListenerManager.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/eventlistener/EventListenerManager.java
Outdated
Show resolved
Hide resolved
electrum
requested changes
Nov 30, 2023
Member
electrum
left a comment
electrum
left a comment
There was a problem hiding this comment.
We should add an explicit shutdown method, like Connector
dominikzalewski
force-pushed
the
plugin_lifecycle_manager
branch
3 times, most recently
from
f7a5683 to
892a6f4
Compare
Member
Author
|
Changed as requested:
|
wendigo
reviewed
Nov 30, 2023
core/trino-spi/src/main/java/io/trino/spi/eventlistener/EventListener.java
Outdated
Show resolved
Hide resolved
wendigo
reviewed
Nov 30, 2023
core/trino-spi/src/main/java/io/trino/spi/eventlistener/EventListener.java
Outdated
Show resolved
Hide resolved
wendigo
changed the title
Contributor
|
Overall LGTM. Please fix |
wendigo
approved these changes
Nov 30, 2023
Contributor
|
And this failure is related: |
dominikzalewski
force-pushed
the
plugin_lifecycle_manager
branch
4 times, most recently
from
460c49c to
3504ba0
Compare
wendigo
reviewed
Nov 30, 2023
core/trino-main/src/main/java/io/trino/eventlistener/EventListenerManager.java
Outdated
Show resolved
Hide resolved
wendigo
reviewed
Nov 30, 2023
core/trino-spi/src/main/java/io/trino/spi/eventlistener/EventListener.java
Outdated
Show resolved
Hide resolved
dominikzalewski
force-pushed
the
plugin_lifecycle_manager
branch
from
3504ba0 to
5827c75
Compare
wendigo
reviewed
Nov 30, 2023
|
|
||
| eventListenerManager.addEventListener(listener); | ||
| eventListenerManager.loadEventListeners(); | ||
| eventListenerManager.shutdown(); |
Contributor
There was a problem hiding this comment.
nit: you could test here that second shutdown is a no-op for the event listener (no change requested)
Contributor
|
LGTM @dominikzalewski. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
@PreDestroy and @PostCreate annotations are processed on EventListener methods.
Release notes
( X ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: