Merged
Conversation
findepi
added
the
no-release-notes
electrum
approved these changes
Nov 30, 2023
Member
There was a problem hiding this comment.
We don't need these annotations anymore on this private constructor
Member
There was a problem hiding this comment.
Do we still need to annotate parameters, if the parameter names match the JSON? I know that records are handled automatically.
Member
Author
There was a problem hiding this comment.
I am eager to believe we do not. I think it would applied to many other classes, so i will keep this as-is in this pr
Remove public constructor that is not supposed to be called and replace it with a JSON-serialization-only factory method. Factory method access can be controlled with `@DoNotCall`.
findepi
force-pushed
the
findepi/seal-tablescannode-api-9cddbe
branch
from
f6e255e to
c35359e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove public constructor that is not supposed to be called and replace it with a JSON-serialization-only factory method. Factory method access can be controlled with
@DoNotCall.