Skip to content

Remove useless @Flaky from JUnit tests #19951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
findepi merged 1 commit into from
Nov 29, 2023
Merged

Remove useless @Flaky from JUnit tests #19951

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 0 additions & 39 deletions plugin/trino-ignite/src/test/java/io/trino/plugin/ignite/TestIgniteConnectorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@
import io.trino.testing.TestingConnectorBehavior;
import io.trino.testing.sql.SqlExecutor;
import io.trino.testing.sql.TestTable;
import io.trino.testng.services.Flaky;
import org.intellij.lang.annotations.Language;
import org.junit.jupiter.api.Test;

import java.util.List;
Expand All @@ -42,10 +40,6 @@
public class TestIgniteConnectorTest
extends BaseJdbcConnectorTest
{
private static final String SCHEMA_CHANGE_OPERATION_FAIL_ISSUE = "https://github.com/trinodb/trino/issues/14391";
@Language("RegExp")
private static final String SCHEMA_CHANGE_OPERATION_FAIL_MATCH = "Schema change operation failed: Thread got interrupted while trying to acquire table lock.";

private TestingIgniteServer igniteServer;

@Override
Expand Down Expand Up @@ -338,7 +332,6 @@ protected void verifyConcurrentAddColumnFailurePermissible(Exception e)

@Test
@Override
@Flaky(issue = SCHEMA_CHANGE_OPERATION_FAIL_ISSUE, match = SCHEMA_CHANGE_OPERATION_FAIL_MATCH)
public void testDropAndAddColumnWithSameName()
{
// Override because Ignite can access old data after dropping and adding a column with same name
Expand All @@ -351,38 +344,6 @@ public void testDropAndAddColumnWithSameName()
}
}

@Test
@Override
@Flaky(issue = SCHEMA_CHANGE_OPERATION_FAIL_ISSUE, match = SCHEMA_CHANGE_OPERATION_FAIL_MATCH)
public void testAddColumn()
{
super.testAddColumn();
}

@Test
@Override
@Flaky(issue = SCHEMA_CHANGE_OPERATION_FAIL_ISSUE, match = SCHEMA_CHANGE_OPERATION_FAIL_MATCH)
public void testDropColumn()
{
super.testDropColumn();
}

@Test
@Override
@Flaky(issue = SCHEMA_CHANGE_OPERATION_FAIL_ISSUE, match = SCHEMA_CHANGE_OPERATION_FAIL_MATCH)
public void testAlterTableAddLongColumnName()
{
super.testAlterTableAddLongColumnName();
}

@Test
@Override
@Flaky(issue = SCHEMA_CHANGE_OPERATION_FAIL_ISSUE, match = SCHEMA_CHANGE_OPERATION_FAIL_MATCH)
public void testAddAndDropColumnName()
{
super.testAddAndDropColumnName();
}

@Override
protected TestTable simpleTable()
{
Expand Down
4 changes: 0 additions & 4 deletions plugin/trino-memory/src/test/java/io/trino/plugin/memory/TestMemoryConnectorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@
import io.trino.testing.QueryRunner;
import io.trino.testing.TestingConnectorBehavior;
import io.trino.testing.sql.TestTable;
import io.trino.testng.services.Flaky;
import io.trino.tpch.TpchTable;
import org.intellij.lang.annotations.Language;
import org.junit.jupiter.api.Test;
Expand Down Expand Up @@ -134,8 +133,6 @@ public void testSelect()
}

@Test
// TODO (https://github.com/trinodb/trino/issues/8691) fix the test
@Flaky(issue = "https://github.com/trinodb/trino/issues/8691", match = "ComparisonFailure: expected:<LongCount\\{total=\\[\\d+]}> but was:<(LongCount\\{total=\\[\\d+]}|null)>")
public void testCustomMetricsScanFilter()
{
Metrics metrics = collectCustomMetrics("SELECT partkey FROM part WHERE partkey % 1000 > 0");
Expand All @@ -145,7 +142,6 @@ public void testCustomMetricsScanFilter()
}

@Test
@Flaky(issue = "https://github.com/trinodb/trino/issues/8691", match = "ComparisonFailure: expected:<LongCount\\{total=\\[\\d+]}> but was:<(LongCount\\{total=\\[\\d+]}|null)>")
public void testCustomMetricsScanOnly()
{
Metrics metrics = collectCustomMetrics("SELECT partkey FROM part");
Expand Down
10 changes: 0 additions & 10 deletions ...n/trino-sqlserver/src/test/java/io/trino/plugin/sqlserver/BaseSqlServerConnectorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
import io.trino.sql.planner.plan.FilterNode;
import io.trino.testing.TestingConnectorBehavior;
import io.trino.testing.sql.TestTable;
import io.trino.testng.services.Flaky;
import org.junit.jupiter.api.Test;

import java.util.List;
Expand Down Expand Up @@ -124,15 +123,6 @@ public void testReadFromView()
onRemoteDatabase().execute("DROP VIEW IF EXISTS test_view");
}

// TODO (https://github.com/trinodb/trino/issues/10846): Test is expected to be flaky because tests execute in parallel
@Flaky(issue = "https://github.com/trinodb/trino/issues/10846", match = "was deadlocked on lock resources with another process and has been chosen as the deadlock victim")
@Test
@Override
public void testSelectInformationSchemaColumns()
{
super.testSelectInformationSchemaColumns();
}

@Override
protected void verifyAddNotNullColumnToNonEmptyTableFailurePermissible(Throwable e)
{
Expand Down
2 changes: 0 additions & 2 deletions ...n/trino-sqlserver/src/test/java/io/trino/plugin/sqlserver/TestSqlServerConnectorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
import io.trino.testing.QueryRunner;
import io.trino.testing.sql.SqlExecutor;
import io.trino.testing.sql.TestTable;
import io.trino.testng.services.Flaky;
import org.jdbi.v3.core.Handle;
import org.jdbi.v3.core.Jdbi;
import org.junit.jupiter.api.Test;
Expand Down Expand Up @@ -91,7 +90,6 @@ private void testCreateTableAsSelectWriteBulkiness(boolean bulkCopyForWrite, boo
assertUpdate("DROP TABLE " + table);
}

@Flaky(issue = "fn_dblog() returns information only about the active portion of the transaction log, therefore it is flaky", match = ".*")
@Test
public void testInsertWriteBulkiness()
throws SQLException
Expand Down
2 changes: 0 additions & 2 deletions testing/trino-tests/src/test/java/io/trino/tests/TestQuerySerializationFailures.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
import io.trino.testing.AbstractTestQueryFramework;
import io.trino.testing.DistributedQueryRunner;
import io.trino.testing.QueryRunner;
import io.trino.testng.services.Flaky;
import org.junit.jupiter.api.Test;

import java.util.Set;
Expand All @@ -48,7 +47,6 @@ protected QueryRunner createQueryRunner()
}

@Test
@Flaky(issue = "https://github.com/trinodb/trino/issues/4173", match = "\\QExpected query to fail: SELECT * FROM (VALUES BOGUS(true), BOGUS(false), BOGUS(true))")
public void shouldFailOnFirstSerializationError()
{
// BOGUS(value) returns BogusType that fails to serialize when value is true
Expand Down