Ensure jq exists before executing the script#19945
Merged
wendigo merged 1 commit intotrinodb:masterfrom Dec 5, 2023
Merged
Conversation
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
electrum
approved these changes
Nov 30, 2023
Member
Author
|
@electrum I think I just got added to the CLA repo. Could you rerun the check? |
Member
Author
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
4b9a817 to
9ce8bb2
Compare
wendigo
approved these changes
Dec 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
While running the docker image build on a new fresh laptop, I just noticed that
build.shscript requiresjqto be installed. Added ajqexistence check in the earlier portion of the build script, so that the build fails faster and it is more obvious that it's required.With the change the script outputs the following when
jqdoesn't exist.Additional context and related issues
Before the change, if jq isn't there, the following error message was buried in the log and the docker build actually started.
then the docker image build failed with the following error:
Release notes
(X) This is not user-visible or is docs only, and no release notes are required.
() Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: