[pinot connector]Support pinot connector to read DataTableV4 bytes#19942
[pinot connector]Support pinot connector to read DataTableV4 bytes#19942ebyhr merged 1 commit intotrinodb:masterfrom
Conversation
plugin/trino-pinot/src/main/java/io/trino/plugin/pinot/PinotSegmentPageSource.java
Outdated
Show resolved
Hide resolved
plugin/trino-pinot/src/main/java/io/trino/plugin/pinot/PinotSegmentPageSource.java
Outdated
Show resolved
Hide resolved
dd82a55 to
5006cc3
Compare
There was a problem hiding this comment.
This behavior is weird to me. There's org.apache.pinot.common.datatable.DataTable#getNullRowIds(int colId) method. Is it possible to use the method instead?
There was a problem hiding this comment.
No, apparently there is an issue in Pinot DataTableV4 for Pinot 0.12.1 to read null bytes value(I need to verify if this is fixed in 1.0), this exception is captured by the test testNullBehavior.
getNullRowIds also returns null from the test.
If you remove the try-catch, the testNullBehavior will fail with NPE
There was a problem hiding this comment.
It would be nice to file an issue in Pinot repository.
There was a problem hiding this comment.
Yes. I'm tracking this.
There was a problem hiding this comment.
This bug is fixed in pinot 1.0.0 release: https://github.com/apache/pinot/pull/10543/files#diff-2276298496d8c930553150ded2ebe21d7caa2b809e450a98618d1bd655c04891L152
Please follow the commit message guideline. https://github.com/trinodb/trino/blob/master/.github/DEVELOPMENT.md#format-git-commit-messages |
5006cc3 to
8bcfe99
Compare
8bcfe99 to
7532ebd
Compare
plugin/trino-pinot/src/main/java/io/trino/plugin/pinot/PinotSegmentPageSource.java
Outdated
Show resolved
Hide resolved
7532ebd to
5c789ea
Compare
5c789ea to
e4f1864
Compare
e4f1864 to
501dfc2
Compare
501dfc2 to
569c00b
Compare
The commit message is too long and please avoid "[Pinot Connector]" prefix. |
Description
Pinot DataTableV4 has a different implementation for reading Bytes:
This PR will check the implementation of DataTable then pick the right method to read it.
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: