Speed up Materialized Views metadata access#19939
Merged
findepi merged 2 commits intotrinodb:masterfrom Dec 13, 2023
Merged
Conversation
github-actions
bot
added
tests:hive
iceberg
Member
|
Test failures seems related |
findepi
approved these changes
Nov 29, 2023
Member
findepi
left a comment
findepi
left a comment
There was a problem hiding this comment.
Mind the failing tests.
Please apply changes as fixups
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergFileOperations.java
Outdated
Show resolved
Hide resolved
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/catalog/glue/TrinoGlueCatalog.java
Outdated
Show resolved
Hide resolved
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/catalog/glue/TrinoGlueCatalog.java
Outdated
Show resolved
Hide resolved
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/catalog/glue/TrinoGlueCatalog.java
Outdated
Show resolved
Hide resolved
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/catalog/glue/TrinoGlueCatalog.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/test/java/io/trino/execution/BaseDataDefinitionTaskTest.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/test/java/io/trino/execution/BaseDataDefinitionTaskTest.java
Outdated
Show resolved
Hide resolved
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/catalog/hms/TrinoHiveCatalog.java
Outdated
Show resolved
Hide resolved
findepi
changed the title
findepi
changed the title
Member
Author
|
Fixups applied, thanks @findepi |
Member
Author
|
Suite 1 failure is unrelated: #16315 |
findepi
reviewed
Dec 1, 2023
core/trino-main/src/test/java/io/trino/execution/BaseDataDefinitionTaskTest.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/test/java/io/trino/execution/TestCreateMaterializedViewTask.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/metadata/MetadataManager.java
Outdated
Show resolved
Hide resolved
Member
|
Only minor changes. Please squash, apply and force push (preferably all at once) |
alexjo2144
force-pushed
the
ajo/mv-properties
branch
2 times, most recently
from
61eb3e1 to
6716e87
Compare
Member
Author
|
Sorry for the double force push, missed a parenthesis the first time... Edit: And another one for conflicts |
alexjo2144
force-pushed
the
ajo/mv-properties
branch
2 times, most recently
from
007dda7 to
317b4e0
Compare
Materialized view properties can be more expensive to retrieve and are unused except for SHOW CREATE queries. Splitting them from the main definition reduces file system calls for metadata queries against the Iceberg connector.
alexjo2144
force-pushed
the
ajo/mv-properties
branch
from
317b4e0 to
05cf609
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Materialized view properties can be more expensive to retrieve
and are unused except for SHOW CREATE queries. Splitting them
from the main definition reduces file system calls for metadata
queries against the Iceberg connector.
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: