Skip to content

Mention SELinux in README Docker section#19938

Merged
mosabua merged 3 commits intotrinodb:masterfrom
dekimir:doc-selinux-off
Dec 7, 2023
Merged

Mention SELinux in README Docker section#19938
mosabua merged 3 commits intotrinodb:masterfrom
dekimir:doc-selinux-off

Conversation

@dekimir
Copy link
Copy Markdown
Contributor

@dekimir dekimir commented Nov 28, 2023

Description

Update README to suggest turning SELinux off, to get rid of errors like this:

Configuration error:
config directory doesn't contain a conf.py file (/docs/src/main/sphinx)

Additional context and related issues

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

... to get rid of errors like this:

Configuration error:
config directory doesn't contain a conf.py file (/docs/src/main/sphinx)
@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Nov 28, 2023

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@mosabua
Copy link
Copy Markdown
Member

mosabua commented Nov 28, 2023

Will also need a signed CLA @dekimir

@dekimir
Copy link
Copy Markdown
Contributor Author

dekimir commented Nov 28, 2023

@mosabua I discovered that I can add a docker flag to exempt the build container from security policies -- please see here. It might be preferable to commit that instead of this PR (though it'll need more testing; I only tested it on my Fedora 38 box).

Also, I emailed the signed CLA to the address mentioned by the bot above.

Thanks @mosabua for the sugestion.

Co-authored-by: Manfred Moser <manfred@simpligility.ca>
@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Nov 28, 2023

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@mosabua
Copy link
Copy Markdown
Member

mosabua commented Nov 28, 2023

That could docker script mod could be another PR .. but given that there are other reasons for disabled write access this PR is still valid

@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Nov 28, 2023

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@dekimir
Copy link
Copy Markdown
Contributor Author

dekimir commented Nov 28, 2023

That could docker script mod could be another PR

#19940

@mosabua mosabua self-assigned this Dec 1, 2023
@mosabua
Copy link
Copy Markdown
Member

mosabua commented Dec 6, 2023

@clabot check

@martint
Copy link
Copy Markdown
Member

martint commented Dec 7, 2023

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Dec 7, 2023
@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Dec 7, 2023

The cla-bot has been summoned, and re-checked this pull request!

Copy link
Copy Markdown
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. Thank you.

@mosabua mosabua merged commit f150648 into trinodb:master Dec 7, 2023
@github-actions github-actions bot added this to the 435 milestone Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants