Implement missing overrides in delegating ConnectorPageSource#19929
Merged
raunaqmorarka merged 4 commits intotrinodb:masterfrom Nov 28, 2023
Merged
Implement missing overrides in delegating ConnectorPageSource#19929raunaqmorarka merged 4 commits intotrinodb:masterfrom
raunaqmorarka merged 4 commits intotrinodb:masterfrom
Conversation
github-actions
bot
added
tests:hive
hudi
raunaqmorarka
force-pushed
the
fix-page-source
branch
from
8033fe7 to
9684460
Compare
sopel39
approved these changes
Nov 28, 2023
findepi
reviewed
Nov 28, 2023
| @Test | ||
| public void testEverythingImplemented() | ||
| { | ||
| assertAllMethodsOverridden(ConnectorPageSource.class, IcebergPageSource.class); |
| @Test | ||
| public void testEverythingImplementedConstantPopulatingPageSource() | ||
| { | ||
| assertAllMethodsOverridden(ConnectorPageSource.class, ConstantPopulatingPageSource.class); |
Member
There was a problem hiding this comment.
Ideally that would go into TestConstantPopulatingPageSource
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implement missing overrides in delegating ConnectorPageSource implementations
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: