Skip to content

Fix flaky TestIcebergFileMetastoreCreateTableFailure#19925

Merged
ebyhr merged 1 commit intotrinodb:masterfrom
ebyhr:ebi/iceberg-flaky-test
Nov 28, 2023
Merged

Fix flaky TestIcebergFileMetastoreCreateTableFailure#19925
ebyhr merged 1 commit intotrinodb:masterfrom
ebyhr:ebi/iceberg-flaky-test

Conversation

@ebyhr
Copy link
Member

@ebyhr ebyhr commented Nov 28, 2023

Description

Error:  io.trino.plugin.iceberg.catalog.file.TestIcebergFileMetastoreCreateTableFailure.testCreateTableFailureMetadataCleanedUp -- Time elapsed: 0.014 s <<< FAILURE!
java.lang.AssertionError: 

Expecting throwable message:
  "Test-simulated metastore runtime exception"
to contain:
  "Test-simulated metastore schema not found exception"
but did not.

https://github.com/trinodb/trino/actions/runs/7010135638/job/19071177674

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

@cla-bot cla-bot bot added the cla-signed label Nov 28, 2023
@ebyhr ebyhr requested a review from martint November 28, 2023 00:16
@github-actions github-actions bot added the iceberg Iceberg connector label Nov 28, 2023
@ebyhr ebyhr requested a review from findepi November 28, 2023 00:16
@ebyhr ebyhr merged commit 8771e14 into trinodb:master Nov 28, 2023
@ebyhr ebyhr deleted the ebi/iceberg-flaky-test branch November 28, 2023 01:23
@github-actions github-actions bot added this to the 434 milestone Nov 28, 2023
import static org.junit.jupiter.api.parallel.ExecutionMode.SAME_THREAD;

@TestInstance(PER_CLASS)
@Execution(SAME_THREAD) // testException is shared mutable state
Copy link
Member

@findepi findepi Nov 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test used to be marked @Test(singleThreaded = true) // testException is a shared mutable state and it got lost when migrating to JUnit. thanks @ebyhr for adding it back

I fully understand that it is obvious that mistakes may happen, but maybe there is a way to check if there are any other cases like this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed iceberg Iceberg connector

Development

Successfully merging this pull request may close these issues.

3 participants