Skip to content

Fix TestMySqlTypeMapping.testTimeFromMySql #19901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ebyhr merged 1 commit into from
Nov 27, 2023
Merged

Fix TestMySqlTypeMapping.testTimeFromMySql #19901

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions plugin/trino-mysql/src/test/java/io/trino/plugin/mysql/TestMySqlTypeMapping.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -599,13 +599,13 @@ private void testDate(ZoneId sessionZone)
@Test
public void testTimeFromMySql()
{
testTimestampFromMySql(UTC);
testTimestampFromMySql(ZoneId.systemDefault());
testTimeFromMySql(UTC);
testTimeFromMySql(ZoneId.systemDefault());
// no DST in 1970, but has DST in later years (e.g. 2018)
testTimestampFromMySql(ZoneId.of("Europe/Vilnius"));
testTimeFromMySql(ZoneId.of("Europe/Vilnius"));
// minutes offset change since 1970-01-01, no DST
testTimestampFromMySql(ZoneId.of("Asia/Kathmandu"));
testTimestampFromMySql(TestingSession.DEFAULT_TIME_ZONE_KEY.getZoneId());
testTimeFromMySql(ZoneId.of("Asia/Kathmandu"));
testTimeFromMySql(TestingSession.DEFAULT_TIME_ZONE_KEY.getZoneId());
Copy link
Copy Markdown
Member Author

@ebyhr ebyhr Nov 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relates to b561a33

}

private void testTimeFromMySql(ZoneId sessionZone)
Expand Down