Minor code docs in EventDrivenFaultTolerantQueryScheduler #19893
Merged
losipiuk merged 1 commit intotrinodb:masterfrom Nov 27, 2023
Conversation
findepi
added
the
no-release-notes
losipiuk
reviewed
Nov 24, 2023
| Optional<Throwable> failure = Optional.empty(); | ||
| try { | ||
| // schedule() is the main logic, but expensive, so we do not want to call it after every event. | ||
| // Process events for some time (measured by schedulingDelayer) before invoking schedule() next time. |
Member
There was a problem hiding this comment.
Actually we are processing all the events from queue (up to EVENT_BUFFER_CAPACITY) - and then calling schedule.
scheduleDelayer is only to pause calling schedule in case we observed failures which we believe may impact newly scheduled tasks too.
Member
Author
There was a problem hiding this comment.
Yes, processEvents() processes all existing events. Not even limited by EVENT_BUFFER_CAPACITY (but it does that in EVENT_BUFFER_CAPACITY portions, repeatedly)
but then, provided that getRemainingDelayInMillis() > 0, we call `processEvents()' waiting for new events (for 1m)
losipiuk
approved these changes
Nov 24, 2023
findepi
deleted the
findepi/add-or-update-code-comments-in-eventdrivenfaulttolerantqueryscheduler-9113d1
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.