Skip to content

Avoid large DF domains unions during add partition #19889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raunaqmorarka merged 1 commit into from
Nov 29, 2023
Merged

Avoid large DF domains unions during add partition #19889

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions core/trino-main/src/main/java/io/trino/server/DynamicFilterService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -764,17 +764,13 @@ private void collectPartitioned(TaskId taskId, Domain domain)
Domain summary = summaryDomains.poll();
// summary can be null as another concurrent summary compaction may be running
if (summary != null) {
long originalSize = summary.getRetainedSizeInBytes();
if (summary.getRetainedSizeInBytes() > domainSizeLimitInBytes) {
summary = summary.simplify(1);
}
if (summary.getRetainedSizeInBytes() > domainSizeLimitInBytes) {
long summarySize = summary.getRetainedSizeInBytes();
if (summarySize > domainSizeLimitInBytes) {
sizeLimitExceeded = true;
allDomain = Domain.all(summary.getType());
summaryDomainsRetainedSizeInBytes.addAndGet(-originalSize);
summaryDomainsRetainedSizeInBytes.addAndGet(-summarySize);
}
else {
summaryDomainsRetainedSizeInBytes.addAndGet(summary.getRetainedSizeInBytes() - originalSize);
summaryDomains.add(summary);
}
}
Expand Down Expand Up @@ -828,6 +824,10 @@ private void unionSummaryDomainsIfNecessary(boolean force)
}

Domain union = union(domains);
// Avoid large unions with domains that exceed size limit
if ((summaryDomainsRetainedSizeInBytes.get() - domainsRetainedSizeInBytes + union.getRetainedSizeInBytes()) > domainSizeLimitInBytes) {
union = union.simplify(1);
}
summaryDomainsRetainedSizeInBytes.addAndGet(union.getRetainedSizeInBytes() - domainsRetainedSizeInBytes);
long currentSize = summaryDomainsRetainedSizeInBytes.get();
verify(currentSize >= 0, "currentSize is expected to be greater than or equal to zero: %s", currentSize);
Expand Down
18 changes: 10 additions & 8 deletions core/trino-main/src/main/java/io/trino/sql/planner/LocalDynamicFilterConsumer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,16 +112,12 @@ public void addPartition(TupleDomain<DynamicFilterId> domain)
TupleDomain<DynamicFilterId> summary = summaryDomains.poll();
// summary can be null as another concurrent summary compaction may be running
if (summary != null) {
long originalSize = getRetainedSizeInBytes(summary);
if (originalSize > domainSizeLimitInBytes) {
summary = summary.simplify(1);
}
if (getRetainedSizeInBytes(summary) > domainSizeLimitInBytes) {
summaryDomainsRetainedSizeInBytes.addAndGet(-originalSize);
long summarySize = getRetainedSizeInBytes(summary);
if (summarySize > domainSizeLimitInBytes) {
summaryDomainsRetainedSizeInBytes.addAndGet(-summarySize);
sizeLimitExceeded = true;
}
else {
summaryDomainsRetainedSizeInBytes.addAndGet(getRetainedSizeInBytes(summary) - originalSize);
summaryDomains.add(summary);
}
}
Expand Down Expand Up @@ -201,7 +197,13 @@ private void unionSummaryDomainsIfNecessary(boolean force)
}

TupleDomain<DynamicFilterId> union = columnWiseUnion(domains);
summaryDomainsRetainedSizeInBytes.addAndGet(getRetainedSizeInBytes(union) - domainsRetainedSizeInBytes);
long unionSize = getRetainedSizeInBytes(union);
// Avoid large unions with domains that exceed size limit
if ((summaryDomainsRetainedSizeInBytes.get() - domainsRetainedSizeInBytes + unionSize) > domainSizeLimitInBytes) {
union = union.simplify(1);
unionSize = getRetainedSizeInBytes(union);
}
summaryDomainsRetainedSizeInBytes.addAndGet(unionSize - domainsRetainedSizeInBytes);
long currentSize = summaryDomainsRetainedSizeInBytes.get();
verify(currentSize >= 0, "currentSize is expected to be greater than or equal to zero: %s", currentSize);
summaryDomains.add(union);
Expand Down