Skip to content

Partial revert of increase split scheduling config #19877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sopel39 merged 1 commit into from
Nov 27, 2023
Merged

Partial revert of increase split scheduling config #19877

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions core/trino-main/src/main/java/io/trino/execution/TaskManagerConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,10 +56,10 @@ public class TaskManagerConfig
private boolean shareIndexLoading;
private int maxWorkerThreads = Runtime.getRuntime().availableProcessors() * 2;
private Integer minDrivers;
private int initialSplitsPerNode = Runtime.getRuntime().availableProcessors() * 4;
private int initialSplitsPerNode = maxWorkerThreads;
private int minDriversPerTask = 3;
private int maxDriversPerTask = Integer.MAX_VALUE;
private Duration splitConcurrencyAdjustmentInterval = new Duration(1, TimeUnit.SECONDS);
private Duration splitConcurrencyAdjustmentInterval = new Duration(100, TimeUnit.MILLISECONDS);

private DataSize sinkMaxBufferSize = DataSize.of(32, Unit.MEGABYTE);
private DataSize sinkMaxBroadcastBufferSize = DataSize.of(200, Unit.MEGABYTE);
Expand Down
4 changes: 2 additions & 2 deletions core/trino-main/src/test/java/io/trino/execution/TestTaskManagerConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@ public void testDefaults()
{
assertRecordedDefaults(recordDefaults(TaskManagerConfig.class)
.setThreadPerDriverSchedulerEnabled(false)
.setInitialSplitsPerNode(Runtime.getRuntime().availableProcessors() * 4)
.setSplitConcurrencyAdjustmentInterval(new Duration(1, TimeUnit.SECONDS))
.setInitialSplitsPerNode(Runtime.getRuntime().availableProcessors() * 2)
.setSplitConcurrencyAdjustmentInterval(new Duration(100, TimeUnit.MILLISECONDS))
.setStatusRefreshMaxWait(new Duration(1, TimeUnit.SECONDS))
.setInfoUpdateInterval(new Duration(3, TimeUnit.SECONDS))
.setTaskTerminationTimeout(new Duration(1, TimeUnit.MINUTES))
Expand Down