Remove testReadMetadataWithRelationsConcurrentModifications test#19872
Merged
findepi merged 1 commit intotrinodb:masterfrom Nov 23, 2023
Conversation
findepi
force-pushed
the
findepi/remove-testreadmetadatawithrelationsconcurrentmodifications-test-935d5a
branch
from
13dceff to
3f65ff7
Compare
This test covers an important aspect of Trino connectors -- metadata listing should work also while tables/views/materialized views are being created or dropped. It helped discover real problems, e.g. - in Iceberg, that's why it was created - in Kudu: trinodb#12974, - in SQL Server https://github.com/trinodb/trino/blob/8edaa86c6b43e5f5fe03bb9427d3f26439a60d15/plugin/trino-sqlserver/src/test/java/io/trino/plugin/sqlserver/BaseSqlServerConnectorTest.java#L151-L152 However, this turned out to be hard to test. The existing test is pretty complicated, takes a lot of time, has high timeout value and remains one of the more flaky tests. The test author does not know how to make it robust and perhaps does not want to remain as the author of the top flaky test in the project.
findepi
force-pushed
the
findepi/remove-testreadmetadatawithrelationsconcurrentmodifications-test-935d5a
branch
from
3f65ff7 to
d9f1495
Compare
kokosing
approved these changes
Nov 23, 2023
sopel39
approved these changes
Nov 23, 2023
wendigo
approved these changes
Nov 23, 2023
Member
@findepi did you happen to talk with the author? |
Contributor
|
|
findepi
deleted the
findepi/remove-testreadmetadatawithrelationsconcurrentmodifications-test-935d5a
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test covers an important aspect of Trino connectors -- metadata
listing should work also while tables/views/materialized views are being
created or dropped. It helped discover real problems, e.g.
trino/plugin/trino-sqlserver/src/test/java/io/trino/plugin/sqlserver/BaseSqlServerConnectorTest.java
Lines 151 to 152 in 8edaa86
However, this turned out to be hard to test. The existing test is pretty complicated, takes a lot of time, has high timeout value and remains one of the more flaky tests. The test author does not know how to make it robust and perhaps does not want to remain as the author of the top flaky test in the project.
Fixes #19747
Fixes #14230