Some clarifications in documentation of File-Based Access Control#19861
Merged
mosabua merged 2 commits intotrinodb:masterfrom Nov 28, 2023
Merged
Some clarifications in documentation of File-Based Access Control#19861mosabua merged 2 commits intotrinodb:masterfrom
mosabua merged 2 commits intotrinodb:masterfrom
Conversation
The information in that paragraph are important to fully understand the
semantics of FBAC, but several bug reports indicate that it's easy to
miss. Perhaps moving it before the `:::{note}` section will make it
harder to miss.
mosabua
requested changes
Nov 22, 2023
Member
There was a problem hiding this comment.
Suggested change
| For each rule set, permission is based on the first matching rule read from top | |
| For each rule set, permission is based on the first matching rule read from the top |
Member
There was a problem hiding this comment.
Suggested change
| to bottom. If no rule matches, access is denied. If no rules are provided at | |
| to the bottom of the configuration file. If no rule matches, access is denied. If no rules are provided at |
Member
There was a problem hiding this comment.
Suggested change
| all, then access is granted. If the latter behavior is not desired, it's easy to | |
| all, then access is granted. You can remove access grant |
Member
There was a problem hiding this comment.
Suggested change
| remove it by adding a section with empty set of rules at that particular level, | |
| by adding a section with an empty set of rules at that particular level, |
Member
There was a problem hiding this comment.
Suggested change
| e.g.: | |
| for example: |
Member
There was a problem hiding this comment.
Suggested change
| At the catalog level one would have to add a single "dummy" rule for each | |
| At the catalog level you have to add a single "dummy" rule for each |
Member
There was a problem hiding this comment.
Suggested change
| accessible catalog, though. | |
| accessible catalog. |
Member
|
Related - #17689 |
Member
|
Could you also address the questions from #18370 ? |
ksobolew
force-pushed
the
kudi/fbac-docs-clarification
branch
from
8021cea to
149c868
Compare
Contributor
Author
I would like to, but I can't tell what is the core issue there |
mosabua
approved these changes
Nov 28, 2023
Including some instructions on how to remove that behavior if it's not desired.
mosabua
force-pushed
the
kudi/fbac-docs-clarification
branch
from
149c868 to
8c61259
Compare
Member
|
Good to go now. Thank you @ksobolew |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Move a paragraph slightly higher in FBAC docs: The information in that paragraph are important to fully understand the semantics of FBAC, but several bug reports indicate that it's easy to miss. Perhaps moving it before the
:::{note}section will make it harder to miss.Emphasize and clarify behavior when there are no FBAC schema rules, including some instructions on how to remove that behavior if it's not desired.
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: