Skip to content

Unimplement DirectExchangeBuffer for TASK retries#19853

Merged
findepi merged 2 commits intotrinodb:masterfrom
findepi:findepi/unimplement-directexchangebuffer-for-task-retries-f0ea84
Nov 23, 2023
Merged

Unimplement DirectExchangeBuffer for TASK retries#19853
findepi merged 2 commits intotrinodb:masterfrom
findepi:findepi/unimplement-directexchangebuffer-for-task-retries-f0ea84

Conversation

@findepi
Copy link
Copy Markdown
Member

@findepi findepi commented Nov 21, 2023

The class is not used for TASK-level retries.

@findepi findepi added the no-release-notes This pull request does not require release notes entry label Nov 21, 2023
@cla-bot cla-bot bot added the cla-signed label Nov 21, 2023
@findepi
Copy link
Copy Markdown
Member Author

findepi commented Nov 21, 2023

The class is not used for TASK-level retries.

At least according to my understanding.

@findepi
Copy link
Copy Markdown
Member Author

findepi commented Nov 22, 2023

CI #16315

Copy link
Copy Markdown
Member

@losipiuk losipiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks valid

@findepi findepi merged commit 766f7b2 into trinodb:master Nov 23, 2023
@findepi findepi deleted the findepi/unimplement-directexchangebuffer-for-task-retries-f0ea84 branch November 23, 2023 12:21
@github-actions github-actions bot added this to the 434 milestone Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed no-release-notes This pull request does not require release notes entry

Development

Successfully merging this pull request may close these issues.

2 participants