Fix TestShardOrganizer.testShardOrganizerInProgress flakiness#19845
Merged
findepi merged 1 commit intotrinodb:masterfrom Nov 22, 2023
Conversation
findepi
added
test
no-release-notes
findepi
force-pushed
the
findepi/fix-testshardorganizer-testshardorganizerinprogress-flakiness-30bc37
branch
from
a84e7c6 to
32f52dd
Compare
hashhar
approved these changes
Nov 22, 2023
wendigo
approved these changes
Nov 22, 2023
Contributor
wendigo
left a comment
wendigo
left a comment
There was a problem hiding this comment.
Mind the error-prone failure
There was a race, the test job was sleeping for only 10ms. However, since GC pause is possible, sleeping "long enough" should be measured in seconds. Use a latch for synchronization instead of fixed sleep time.
findepi
force-pushed
the
findepi/fix-testshardorganizer-testshardorganizerinprogress-flakiness-30bc37
branch
from
32f52dd to
8de3333
Compare
findepi
deleted the
findepi/fix-testshardorganizer-testshardorganizerinprogress-flakiness-30bc37
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a race, the test job was sleeping for only 10ms. However, since GC pause is possible, sleeping "long enough" should be measured in seconds. Use a latch for synchronization instead of fixed sleep time.
Fixes #11252