Improve collection assertions#19841
Merged
findepi merged 4 commits intotrinodb:masterfrom Nov 21, 2023
Merged
Conversation
Use `AbstractIterableAssert#contains` instead of `assertThat(list.contains(...)).isTrue()`. The `isTrue` version produces less useful error messages.
Use `AbstractMapAssert#containsKey` instead of `assertThat(map.containsKey(...)).isTrue()`. The `isTrue` version produces less useful error messages.
Use `AbstractMapAssert#containsEntry` instead of `assertThat(map.get(...)).isEqualTo(...)`. The `isEqualTo` version produces less useful error message, because it does not know the map key being asserted.
github-actions
bot
added
jdbc
losipiuk
approved these changes
Nov 21, 2023
Member
Author
|
CI #11252 |
ksobolew
approved these changes
Nov 21, 2023
Contributor
ksobolew
left a comment
ksobolew
left a comment
There was a problem hiding this comment.
My favourite kind of commit! 🙌
Member
Author
|
CI #16315 (twice) |
findepi
deleted the
findepi/improve-map-assertions-for-map-entries-b0d9bc
branch
Member
|
No release notes since this it testing stuff |
findepi
added
the
no-release-notes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use assertion patterns that produce useful error messages on failures.
AbstractIterableAssert#containsinstead ofassertThat(list.contains(...)).isTrue()AbstractMapAssert#containsKeyinstead ofassertThat(map.containsKey(...)).isTrue().AbstractMapAssert#containsEntryinstead ofassertThat(map.get(...)).isEqualTo(...)