Remove redundant analyzeColumns from IcebergTableHandle#19830
Merged
findepi merged 3 commits intotrinodb:masterfrom Nov 21, 2023
Merged
Remove redundant analyzeColumns from IcebergTableHandle#19830findepi merged 3 commits intotrinodb:masterfrom
findepi merged 3 commits intotrinodb:masterfrom
Conversation
github-actions
bot
added
tests:hive
iceberg
findepi
force-pushed
the
findepi/ice-cl
branch
from
aa3fb16 to
378da35
Compare
marton-bod
reviewed
Nov 20, 2023
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergTableHandle.java
Outdated
Show resolved
Hide resolved
The information was not correct when ANALYZE was invoked without `columns` parameter -- instead of all columns, an empty set was there. The information can be replaced with a single boolean.
findepi
force-pushed
the
findepi/ice-cl
branch
from
378da35 to
23a8a7a
Compare
losipiuk
approved these changes
Nov 20, 2023
marton-bod
approved these changes
Nov 20, 2023
Member
findepi
added
the
no-release-notes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The information was not correct when ANALYZE was invoked without
columnsparameter -- instead of all columns, an empty set was there.The information can be replaced with a single boolean.