Remove HiveMetastoreDecorator and simplify metastore creation#19814
Merged
dain merged 1 commit intotrinodb:masterfrom Nov 28, 2023
Merged
Remove HiveMetastoreDecorator and simplify metastore creation#19814dain merged 1 commit intotrinodb:masterfrom
dain merged 1 commit intotrinodb:masterfrom
Conversation
github-actions
bot
added
tests:hive
iceberg
electrum
approved these changes
Nov 25, 2023
dain
force-pushed
the
simplify-decorated-hive-metastore
branch
from
1563f8c to
0a84f9e
Compare
dain
force-pushed
the
simplify-decorated-hive-metastore
branch
from
0a84f9e to
5eda27a
Compare
lukasz-stec
reviewed
Dec 12, 2023
| @Override | ||
| public HiveMetastore decorate(HiveMetastore hiveMetastore) | ||
| { | ||
| return new TracingHiveMetastore(tracer, hiveMetastore); |
Member
There was a problem hiding this comment.
@dain with this we dont trace metastore calls anymore. Was this intentional?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.