Remove deprecated filterColumns overload#19800
Merged
findepi merged 4 commits intotrinodb:masterfrom Nov 17, 2023
Merged
Conversation
Remove overloads of `Connector.beginTransaction` and `Connector.getMetadata` deprecated since 2021.
It's been deprecated since January 2023.
It's been deprecated for 10+ releases.
findepi
commented
Nov 17, 2023
| return tableColumns.entrySet().stream() | ||
| .collect(toImmutableMap( | ||
| Entry::getKey, | ||
| // TODO call delegate.filterColumns in bulk |
| { | ||
| Optional<SchemaTableName> sourceTableName = getSourceTableNameFromSystemTable(systemTableProviders, tableName); | ||
| if (sourceTableName.isPresent()) { | ||
| // TODO system table may have quite different columns that its source table. It's unclear why it's a good idea to conflate the two. |
findepi
added
the
no-release-notes
Member
Author
|
CI #19799 |
kokosing
approved these changes
Nov 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.