Add junit-extensions to test classpaths#19797
Merged
findepi merged 1 commit intotrinodb:masterfrom Nov 17, 2023
Merged
Conversation
wendigo
approved these changes
Nov 17, 2023
findepi
force-pushed
the
findepi/add-junit-extensions-to-test-classpaths-8c631b
branch
from
5dcc6f0 to
6e94622
Compare
`junit-extensions` is necessary safety extensions to JUnit, preventing
JUnit "UX trap" which makes overridden tests silently skipped. It should
be on every module's classpath.
For the record, the modules were identified using
find -name pom.xml | grep -vFxf <(find -name pom.xml -exec grep -l junit-extensions {} +)
And some left out.
findepi
force-pushed
the
findepi/add-junit-extensions-to-test-classpaths-8c631b
branch
from
6e94622 to
3b28739
Compare
Member
Author
|
CI #19799 |
findepi
added
test
no-release-notes
findepi
deleted the
findepi/add-junit-extensions-to-test-classpaths-8c631b
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
junit-extensionsis necessary safety extensions to JUnit, preventing JUnit "UX trap" which makes overridden tests silently skipped. It should be on every module's classpath.For the record, the modules were identified using