Skip to content

Fix X-Trino-Authorization-User typo #19763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
findepi merged 1 commit into from
Nov 17, 2023
Merged

Fix X-Trino-Authorization-User typo #19763

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/trino-main/src/test/java/io/trino/server/security/TestResourceSecurity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -977,7 +977,7 @@ public void testResourceSecurityImpersonation()
server.getInstance(Key.get(PasswordAuthenticatorManager.class)).setAuthenticators(TestResourceSecurity::authenticate);
HttpServerInfo httpServerInfo = server.getInstance(Key.get(HttpServerInfo.class));

// Authenticated user TEST_USER_LOGIN impersonates impersonated-user by passing request header X-Trino-Authorization-User
// Authenticated user TEST_USER_LOGIN impersonates impersonated-user by passing request header X-Trino-User
Request request = new Request.Builder()
.url(getLocation(httpServerInfo.getHttpsUri(), "/protocol/identity"))
.addHeader("Authorization", Credentials.basic(TEST_USER_LOGIN, TEST_PASSWORD))
Expand Down
9 changes: 5 additions & 4 deletions docs/src/main/sphinx/develop/client-protocol.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,11 +218,12 @@ subsequent requests to be consistent with the response headers received.
header in subsequent client requests.
* - `X-Trino-Set-Authorization-User`
- Instructs the client to set the session authorization user in the
`X-Trino-Authorization-User` request header in subsequent client requests.
`X-Trino-User` request header in subsequent client requests.
`X-Trino-Original-User` should also be set.
* - `X-Trino-Reset-Authorization-User`
- Instructs the client to remove `X-Trino-Authorization-User` request header
in subsequent client requests to reset the authorization user back to the
original user.
- Instructs the client to reset `X-Trino-User` request header to its original
value in subsequent client requests and remove `X-Trino-Original-User`
to reset the authorization user back to the original user.
* - `X-Trino-Set-Session`
- The value of the `X-Trino-Set-Session` response header is a string of the
form *property* = *value*. It instructs the client include session property
Expand Down