Fix ArrayIndexOutOfBoundsException when parquet statistics are ignored

[jinyangli34]

Description

Fix ArrayIndexOutOfBoundsException when using parquet ignore statistics. (#19760)
Add unit tests.

Additional context and related issues

parquetTupleDomains and parquetPredicates are empty when ignore statistics is used, can cause exception.

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`19760`)

[findinpath]

CI Failure TestHiveTransactionalTable > testReadFullAcidPartitioned [groups: hive_transactional] is related to #16315

[findinpath]

Thank you @jinyangli34

[findepi]

if ignore-stats, this fills parquetTupleDomains with a series of TupleDomain.all objects, which is not very useful.

ionstead of this, let's change for (int i = 0; i < disjunctTupleDomains.size(); i++) { loop iteration to iterate over parquetTupleDomains.size() instead iof disjunctTupleDomains.size()

[jinyangli34]

That will skip the following blocks.add and blockStarts.add. Is that OK?

[findepi]

@findinpath please chime in

[findinpath]

@findepi i agree with your suggestion.
Adapting the loop to use parquetTupleDomains.size() instead of disjunctTupleDomains.size() should give us the same result - ALL the blocks in the file.
@jinyangli34 the loop https://github.com/trinodb/trino/pull/19761/files#diff-bb16d0894036f6a50fd882558df497a4ddbf2907097b8a33118c4f6ce147753dR240 is to be used only if options.isIgnoreStatistics() is false.

That will skip the following blocks.add and blockStarts.add
This happens now as well right ?

trino/plugin/trino-hive/src/main/java/io/trino/plugin/hive/parquet/ParquetPageSourceFactory.java

Line 281 in e9ba634

break;

[jinyangli34]

Hi @findinpath @findepi, to make sure I understand correctly, parquetTupleDomains will still hold TupleDomain.all objects, not an empty list. Is that correct?

[findinpath]

A slight reworking is needed in the PR.